coiled / benchmarks

BSD 3-Clause "New" or "Revised" License
28 stars 17 forks source link

[TPC-H] Require `scale` argument for Dask queries #1455

Closed hendrikmakait closed 6 months ago

hendrikmakait commented 6 months ago

Having a default for Q11 could lead to the scale used for the data and the query diverging. Requiring it for each query avoids special casing.

hendrikmakait commented 6 months ago

TPC-H tests seem pretty unhappy. Did you mean to move a scale fixture into this PR?

Whoops, looks like I forgot to commit a file.