coiled / benchmarks

BSD 3-Clause "New" or "Revised" License
28 stars 17 forks source link

No notification when tests fail #1544

Open jrbourbeau opened 2 weeks ago

jrbourbeau commented 2 weeks ago

I happened to notice https://github.com/dask/dask/issues/11383 while running a rechunking against the main branch of dask/dask, though that was just a coincidence and it's possible the issue may have gone unnoticed. Nightly CI here also caught this issue (see this run https://github.com/coiled/benchmarks/actions/runs/10755587163/job/29827473440) but there wasn't much visibility into the failure here either (e.g. no issue opened, ping, etc). Likely this is due to our report step in the testing workflow failing (https://github.com/coiled/benchmarks/actions/runs/10755587163/job/29828301952)

TypeError: Cannot read properties of undefined (reading 'create')
    at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35424:16), <anonymous>:5:15)
    at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35425:12)
    at main (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35522:26)
    at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:35497:1
    at /home/runner/work/_actions/actions/github-script/v7/dist/index.js:35553:3
    at Object.<anonymous> (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35556:12)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Module.load (node:internal/modules/cjs/loader:1[20](https://github.com/coiled/benchmarks/actions/runs/10755587163/job/29828301952#step:3:21)8:32)
    at Module._load (node:internal/modules/cjs/loader:1024:12)