Clean up package installation

commaai / agnos-builder

Build AGNOS, the operating system for your comma 3/3X

32 stars 52 forks source link

Clean up package installation #329

Open robin-reckmann opened 2 weeks ago

robin-reckmann commented 2 weeks ago

The apt package installation parts of the agnos build are currently not very well maintained. Lets discuss here how to improve this.

Currently existing:

base_setup.sh
openpilot_dependencies.sh
hardware_setup.sh
install_extras.sh

What should be included (open for discussion):

base_setup.sh

Anything that is needed to boot into a minimal system with network connectivity

openpilot_dependencies.sh

Any libraries or tools that OP requires (ideally this should be maintained within OP repo)

hardware_setup.sh

Not clear, maybe merge with base setup?

install_extras.sh

Any additional tooling that is nice to have but not necessary for OP operation.
Could we excluded from the standard agnos image and pulled in if necessary

robin-reckmann commented 2 weeks ago

base_setup.sh cleanup: #330

adeebshihadeh commented 1 week ago

I think the best way to approach this is to first refactor the build such that it goes: setup agnos-compiler -> compile all the things -> assemble final image. Right now it's all jumbled up, and once we fix that, it'll become more clear how to clean this up.

robin-reckmann commented 1 week ago

I think the best way to approach this is to first refactor the build such that it goes: setup agnos-compiler -> compile all the things -> assemble final image. Right now it's all jumbled up, and once we fix that, it'll become more clear how to clean this up.

How about moving out the compilation into a separate dockerfile and provide the compiled debs and whls to the main docker build?

robin-reckmann commented 1 week ago

@adeebshihadeh I moved the package installation to a separate docker file that is build before the main one. https://github.com/commaai/agnos-builder/pull/354

robin-reckmann commented 5 days ago

I moved the compilation to the top of the main dockerfile instead: https://github.com/commaai/agnos-builder/pull/354