commoncriteria / application

Protection Profile for Application Software
The Unlicense
9 stars 3 forks source link

Grammar issues in application.xml file #163

Open amasino opened 4 years ago

amasino commented 4 years ago

Hi,

I'm consuming this repository to have an xml version of all NIAP protection profiles, PP modules and Extended Packages. I've noticed that the grammar varies between one project and the other.

Specifically, for this Protection Profile, I've noticed the following:

This is the assurance activity that goes in the TSS

All assurance activities appear as orphans and the tag is only used as delimiter:

This is the assurance activity.

This causes issues in the processing of the XML file with XSLT, which is tag oriented.

Thanks, Alejandro Masino

jmcdaniels commented 4 years ago

We will take this comment under consideration during the next planned update. Thank you for the feedback.

jfisherbah commented 9 months ago

With respect to the tags, unclear what the status of the PP was when this comment was originally made but I believe it has been resolved. The text for the EAs exists in their own separate tags which include the actual data element within the tag (at least that is my assumption based on how the evaluation activity is populated now with separate TSS/Guidance/Test tags which I believe EAs didn't have previously).

Please confirm whether the intent of the first part of the comment was met by how the tags are populated now.

With respect to the second point, is the preferred usage although there are some cases where this conflicts with the schema and doesn't add the proper spacing between paragraphs. Historically was used to create a blank paragraph which produced the desired spacing with no limitations, but it is our understanding that this is not best practice because how that gets rendered is not standardized across different browsers. The PP has been migrated to tags in replacement to both line breaks and blank paragraphs within prose, and will be reviewed for areas where this doesn't result in sufficient whitespace being added.

tags still used when no padding is preferred (e.g., when there are multiple dependencies listed in an extended component definition). Note as part of making this update, a reference error in the start of section 5.2 was observed and corrected (reference to security objectives for the TOE pointed to section 5.1 rather than to 4.1).
jmcdaniels commented 1 month ago

@amasino please confirm the above resolves this issue.