I'm switching over from the fork to making a PR directly to avoid failing tests. Pardon me for interrupting the flow of conversation.
Regarding the second point
from_configuration() as a static method. Also poses some questions, since it should return two objects (RobotJoints and ExternalAxes), so it doesn't fit exactly on either, but if I had to choose, I guess RobotJoints being the "primary" one is the better fit.
It made sense to me to add this method to both classes and to allow the user to specify either the group or the joint_names to be included in the compas_rrc object, rather than trying to figure out which of the joints are external and which are internal programmatically.
Regarding python's lack of overloading, are the names ok?
What type of change is this?
[ ] Bug fix in a backwards-compatible manner.
[x] New feature in a backwards-compatible manner.
[ ] Breaking change: bug fix or new feature that involve incompatible API changes.
[ ] Other (e.g. doc update, configuration, etc)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
[x] I ran all tests on my computer and it's all green (i.e. invoke test).
[x] I ran lint on my computer and there are no errors (i.e. invoke lint).
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added necessary documentation (if appropriate)
I'm switching over from the fork to making a PR directly to avoid failing tests. Pardon me for interrupting the flow of conversation.
Regarding the second point
It made sense to me to add this method to both classes and to allow the user to specify either the
group
or thejoint_names
to be included in thecompas_rrc
object, rather than trying to figure out which of the joints are external and which are internal programmatically.Regarding python's lack of overloading, are the names ok?
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.rst
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).