compas-rrc / compas_rrc

Online control for ABB robots over a simple-to-use Python interface.
https://compas-rrc.github.io/compas_rrc/
MIT License
22 stars 6 forks source link

Joints to config #20

Closed beverlylytle closed 3 years ago

beverlylytle commented 3 years ago

I'm switching over from the fork to making a PR directly to avoid failing tests. Pardon me for interrupting the flow of conversation.

Regarding the second point

from_configuration() as a static method. Also poses some questions, since it should return two objects (RobotJoints and ExternalAxes), so it doesn't fit exactly on either, but if I had to choose, I guess RobotJoints being the "primary" one is the better fit.

It made sense to me to add this method to both classes and to allow the user to specify either the group or the joint_names to be included in the compas_rrc object, rather than trying to figure out which of the joints are external and which are internal programmatically.

Regarding python's lack of overloading, are the names ok?

What type of change is this?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

beverlylytle commented 3 years ago

Whoops, hang on. Forgot units conversion.

beverlylytle commented 3 years ago

OK, this is ready for re-review.