conan-io / conan-vs-extension

Conan Extension for Visual Studio
https://marketplace.visualstudio.com/items?itemName=conan-io.conan-vs-extension
MIT License
59 stars 34 forks source link

cleanup the code #113

Closed SSE4 closed 5 years ago

SSE4 commented 5 years ago

we have many left-over from previous attempts of implementation. we need to clean up these thing at some point. these left-overs add unnecessary complexity to the code, and already caused some issues in the past (like in case of .csi magic).

things to review:

jgsogo commented 5 years ago

This is something we should do asap. I would vote to remove everything not needed/used and then to implement it again when we feel like it is the right moment to provide the functionality

SSE4 commented 5 years ago

yeah, I also prefer to remove, unless some code relies on that - we always have Git history if we ever need to re-implement the things

jgsogo commented 5 years ago

I'm moving this issue to next milestone, we have got rid of enough dead code for v1.2. Thanks!

SSE4 commented 5 years ago

@jgsogo I think this is basically done - we have identified and removed all unused/dead code. next step is to complete https://github.com/conan-io/conan-vs-extension/pull/135

jgsogo commented 5 years ago

Ok, I'm sure there are still some functions we are not using or could be simplified, but let's close this issue, probably it is no longer a priority.

It has been nice 👌

image