conan-io / conan-vs-extension

Conan Extension for Visual Studio
https://marketplace.visualstudio.com/items?itemName=conan-io.conan-vs-extension
MIT License
59 stars 34 forks source link

Start streaming output before running the task [skip changelog] #145

Closed jgsogo closed 5 years ago

jgsogo commented 5 years ago

I think this change is needed to print the output before the command finish

jgsogo commented 5 years ago

I'm not sure about the implementation of the AppendLinesFunc function, can it finish the while loop before any output is generated by the conan install command?

SSE4 commented 5 years ago

according to the: https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.process.standardoutput?view=netframework-4.8 it's completely safe:

The redirected StandardOutput stream can be read synchronously or asynchronously. Methods such as Read, ReadLine, and ReadToEnd perform synchronous read operations on the output stream of the process. These synchronous read operations do not complete until the associated Process writes to its StandardOutput stream, or closes the stream.