Update I18nServiceProvider.php

[RamyTalal]

Revert, this broke #12.

[iamgergo]

What is broken exactly?

[RamyTalal]

@iamgergo Only one package of a list of packages is translated. Basically the same bug in #12. When I reverted the code locally the issue was gone.

[RamyTalal]

@iamgergo Update: seems like a new issue. Unrelated to what I assumed.

[iamgergo]

Yes, it looks like your keys contain some special characters.

[RamyTalal]

It worked prior of the change. \u0000*\u0000items looks like the Laravel Collection is being encoded, I have seen this before.

[iamgergo]

I've never seen this. The \u0000 is null character: https://www.fileformat.info/info/unicode/char/0000/index.htm

[RamyTalal]

I know, this happens when the items property is being encoded. Adding })->toArray(); on line 98 fixes the issue.

[iamgergo]

And what if you add the to array at the very end? Just before printing the translations?

[RamyTalal]

On line 101? I get Call to a member function keys() on array

[iamgergo]

Okay, thanks! I'll soon make the release if nothing comes in.

[RamyTalal]

Thank you!

[iamgergo]

As it turns out, this change breaks the code and the tests as well.

Call to a member function merge() on array at /.../I18nServiceProvider.php:73)

I reverted this change, so we need an other solution for that.

[RamyTalal]

What about the initial code? Does that give you errors?

[iamgergo]

Probably not, I'll take a look. If it works well, then we bring back the old code.

[RamyTalal]

Do I need to do a new PR?

[iamgergo]

Yes, please it would be a help. Thanks!

[RamyTalal]

See https://github.com/thepinecode/i18n/pull/22