search

conedevelopment / i18n

Push your Laravel translations to the front-end and use them easily with JavaScript.
https://pineco.de/using-laravels-localization-js/
MIT License
129 stars 21 forks source link

Laravel 9 compatibility #32

Closed gbradley closed 2 years ago

gbradley commented 2 years ago

Hi there, it would be great for this package to support Laravel 9 :)

I think the only change beyond bumping the Composer requirements would be due to Laravel 9 moving the resources/lang folder to the top level of the project. I'm happy to submit a PR for this if that would help, just not 100% certain on how to best test the change.

iamgergo commented 2 years ago

Hi there!

I would gladly accept a PR for this, thank you! I'll merge the shift PR as well soon!

Thank you!

iamgergo commented 2 years ago

@gbradley What do you think, should we drop the support for versions under Laravel 8?

gbradley commented 2 years ago

@iamgergo Probably does make sense to do that and bump the version up; if you like I'll update the PR.

iamgergo commented 2 years ago

Okay, thank you! I merged the shift PR as well.

iamgergo commented 2 years ago

So I updated the dependecies so the versions as well. Soon I'll make a release. Thanks!