search

confluentinc / ksql-images

KSQL platform docker images
Apache License 2.0
6 stars 21 forks source link

chore: replace ADD with COPY in docker files #115

Closed cadonna closed 8 months ago

cadonna commented 9 months ago

As part of FedRAMP M3 Container Hardening Requirements mentioned in this doc, using ADD command is restricted in Dockerfiles.

This PR replaces ADD with COPY in docker files.

https://confluentinc.atlassian.net/browse/KSQL-11502

cla-assistant[bot] commented 9 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

lucasbru commented 9 months ago

If you create a branch with the name apply-bruno it should show up as a separate job that you can run for testing in https://jenkins.confluent.io/job/confluentinc/job/ksql-images

cadonna commented 9 months ago

I do not know on what branches I have to do this. So please do not merge until I find out.

cadonna commented 9 months ago

The change should only go to master.

cadonna commented 9 months ago

I also opened a PR https://github.com/confluentinc/ksql-images/pull/116 from a branch apply-... which triggered builds that also show up here. 🤔 Be aware that those builds build 116 and not this PR.