search

conorhastings / react-native-syntax-highlighter

a syntax highlighter for react native using https://github.com/conorhastings/react-syntax-highlighter under the hood
MIT License
167 stars 25 forks source link

move babel to devDependencies #19

Closed sampi closed 4 years ago

sampi commented 5 years ago

@conorhastings

Babel is not required for using the package, only building it, so it should not be listed as a dependency, but a devDependency.

We're trying to use this package in a monorepo using Yarn workspaces, and we're having issues with Babel 6 clashing with Babel 7. This PR should fix that.

ColinKrist commented 4 years ago

@conorhastings anything preventing this?

conorhastings commented 4 years ago

sorry have so many repos, i miss things sometimes

conorhastings commented 4 years ago

published as 2.1.0

mrtnzlml commented 4 years ago

@conorhastings Thanks! :)

@sampi Could you please remove the internal workaround since this is fixed now? :)