search

consento-org / consento-website

Ghost theme used for consent.org domain
https://consento.org
Other
1 stars 0 forks source link

Remove shadow when not scrolling from menu #33

Closed martinheidegger closed 4 years ago

martinheidegger commented 4 years ago

@consento-org/design correct me if I am wrong, but as far as I understand the shadow below the menu should only be there when the site is not scrolled to top, right?

Tannybunny commented 4 years ago

Yes that was proposed

Torgian commented 4 years ago

Refer to commits: 1 and 2

@martinheidegger Please review.

martinheidegger commented 4 years ago

This looks okay to me. I added a note on how it may be improved but I leave it up to you if you want to do that or just close this issue.

Torgian commented 4 years ago

I implemented your suggestions in commit 41ceb

Torgian commented 4 years ago

See this commit

@martinheidegger I double checked the sass file and I couldn't find anything wrong with the indentation. They are all tab indented. I also implemented your suggestion with the javascript.

toggle is one of those functions that I know about, but never remember ( I always remember classList.add and .remove ). Thanks for the reminder! It makes things more simple.

martinheidegger commented 4 years ago

Cool. Closing this issue.