search

consento-org / consento-website

Ghost theme used for consent.org domain
https://consento.org
Other
1 stars 0 forks source link

Autor display in blog posts are blue #38

Closed martinheidegger closed 4 years ago

martinheidegger commented 4 years ago

On a blog article with authors, like on ./blog/funding-ngi-2019/, the authors are displayed in blue:

Screen Shot 2020-02-05 at 08 08 47
martinheidegger commented 4 years ago

@consento-org/design Can you send a quick layout for this?

marcchataigner-zz commented 4 years ago

https://github.com/consento-org/consento-website/issues/38#issuecomment-582251858

you mean a design on white background?

martinheidegger commented 4 years ago

Yes, very simple

marcchataigner-zz commented 4 years ago

@martinheidegger @Torgian Just replying a bit late here, sorry.

Torgian commented 4 years ago

Refer to commit 82d5702 for fix.

Screen Shot 2020-02-17 at 1 23 18 PM
martinheidegger commented 4 years ago

Let's have this author content display on the white background. With work sans font.

The font is still wrong.

Torgian commented 4 years ago

The font is already WorkSans-Regular. Do you need it to be a different work-sans font?

I did see that the font size and line height were being overridden by ghost styling. The following screenshot is with the base paragraph settings ( 21px, line-height 27px, color rgba(0 0 0 0.87) )

Screen Shot 2020-02-17 at 5 44 21 PM

This is same settings, but using Worksans-Light

Screen Shot 2020-02-17 at 5 47 53 PM

And this is Worksans Medium:

Screen Shot 2020-02-17 at 5 48 50 PM
marcchataigner-zz commented 4 years ago

Great. I feel the Work sans Light is best, no? :-)

Torgian commented 4 years ago

Done. See this commit

Screen Shot 2020-02-17 at 6 48 14 PM
martinheidegger commented 4 years ago

As far as I can see "AUTHOR" is still in the wrong don't.

Torgian commented 4 years ago

My mistake.

Here is a screenshot using WorkSans-SemiBold

Screen Shot 2020-02-18 at 9 10 58 AM

And this uses WorkSans Light

Screen Shot 2020-02-18 at 9 14 03 AM

I think the SemiBold font looks better in this case. @marcchataigner @martinheidegger What do you think?

martinheidegger commented 4 years ago

As a design question: I like the semibold, but the description text font is too large, there should be between 5~10 words fitting in the block, not 3~6

Torgian commented 4 years ago

This is a font size of 1.3em.

Screen Shot 2020-02-18 at 10 24 22 AM

And this is with 1em.

Screen Shot 2020-02-18 at 10 25 42 AM
martinheidegger commented 4 years ago

1em with 1.4em line-height, would be my choice.

Torgian commented 4 years ago

Refer to these commits for the author box p and author box label styling.

Torgian commented 4 years ago

Verified changes on live website:

Screen Shot 2020-02-18 at 10 56 46 AM
martinheidegger commented 4 years ago

LGTM