Top bar font and spacing.

consento-org / consento-website

Ghost theme used for consent.org domain

https://consento.org

Other

1 stars 0 forks source link

Top bar font and spacing. #61

Closed Torgian closed 4 years ago

martinheidegger commented 4 years ago

Lets turn this PR into a fix for all of the problems or, alternatively create new "sub-issues" for which this is a fix.

Torgian commented 4 years ago

Referring #32 and #22

I am adding a few screenshots here of mobile, tablet, and other views for the changes I have made so far in the top navigation bar. These include spacing / centering issues. Please review.

Tablet mode ( the second screenshot ) can be resolved a couple of different ways. I can either change the font-sizes and padding to make the links closer together, or change the menu so that the hamburger menu appears on tablet screens. I think the former would be better.

Torgian commented 4 years ago

See this commit for the following:

Before:

After fix:

This is for tablet view. I reduced the font size from 1em to 0.5 em. This makes it look better and more fluid between different sizes. @marcchataigner @Tannybunny what do you think?

marcchataigner-zz commented 4 years ago

It looks better, more compact indeed. Maybe the visual could even be a bit compacted, so the title + text + visual would all fit on one screen?

martinheidegger commented 4 years ago

Maybe the visual could even be a bit compacted, so the title + text + visual would all fit on one screen?

This PR is in regards to the menu spacing, not the visual, the menu spacing looks good to me. @Torgian maybe its a good idea to focus the screenshots on the relevant elements only?

martinheidegger commented 4 years ago

A rebase is needed to merge this PR.

Torgian commented 4 years ago

Rebase complete. This PR should resolve #22 and #32 and also contribute towards #13

martinheidegger commented 4 years ago

Merging for now. If a new problem arises, let's create a new issue.