search

consento-org / consento-website

Ghost theme used for consent.org domain
https://consento.org
Other
1 stars 0 forks source link

Fix spacing issues #72

Open Torgian opened 4 years ago

Torgian commented 4 years ago

Update: Refer to PR #73 Upon reviewing the page as it stands, there are still a few spacing issues in a few spots.

Too much space below "How does it work" and the icons.

Screen Shot 2020-02-21 at 10 13 00 AM

A bit too much pace below " Our solution " and the paragraph text. In mobile view, it looks fine.

Screen Shot 2020-02-21 at 10 16 57 AM

"The technology" has a lot of space between the title and the paragraph. This was done originally to keep everything more in-line with the code block on the right on desktop view. In the Zeplin file This calls for more space between the first and second paragraphs. @marcchataigner @Tannybunny can you review?

Original:

Screen Shot 2020-02-21 at 10 18 40 AM

Potential change:

Screen Shot 2020-02-21 at 10 22 58 AM

Next, a little too much margin below "Co-ownership" and paragraph below; same with Data integrity and Consento roadmap

Screen Shot 2020-02-21 at 10 25 04 AM

:

Screen Shot 2020-02-21 at 10 24 23 AM Screen Shot 2020-02-21 at 10 25 52 AM
Tannybunny commented 4 years ago

I agree these spacings need to be fixed. I made an example for the "our solution" section, which first of all should not be aligned to the right, this never looks good.

If possible, I would align them to the left and center the whole text block with the image. The space between "h2 "and "p" is 30 pixel and the space between "p" and the button is 60 pixel. Also I think it might be good to change the link of the button to for example https://play.google.com/store/apps/details?id=org.consento.mobile and label it as a download button? If we want people to sign up for the newsletter maybe we should have a separate newsletter section?

Could you try to apply this? We can use the same spacing for the other spaces between a "h2" and "p" I guess

Screen Shot 2020-02-27 at 12 18 44
Torgian commented 4 years ago

Refer to https://github.com/consento-org/consento-website/commit/2d60b9d6727b8e6c6da0322c4872a328abfa9dfd for another fix

Tannybunny commented 4 years ago

Is it possible to center the "our solution" text with the image of the phone ?

Tannybunny commented 4 years ago

Also, I think due to recent changes the positioning of the "Co-ownership of confidential data." illustration (mountain in the background) changed a bit, it's now a bit too close the previous content. If possible, move it a bit more downwards, best would be to center it with the text