containerd / accelerated-container-image

A production-ready remote container image format (overlaybd) and snapshotter based on block-device.
Apache License 2.0
405 stars 73 forks source link

Proposal PR: Userspace Convertor: Add Deduplication Version Support #271

Open estebanreyl opened 6 months ago

estebanreyl commented 6 months ago

Introduce a simple versioning system for the userspace convertor deduplication dbs. This prevents inconsistencies with an existing DB if a new version is used.

What this PR does / why we need it: This is a proposal PR on how to handle versioning for the layer/manifest deduplication going forward. It is not done as is since we still need some way of finding the version of the overlaybd tools to combine with the local deduplication versions. I furthermore propose that major versions for the tools denote a break in the digest outputs. I also updated the sample workload file to include more info and validation as well as added some unit tests. We can probably incorparete that with the tests but tbh I am unclear on how at the moment.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #250

Please check the following list: