Fixed the issue that a new output tag would not be uploaded if a cach…

fourierrr commented 4 weeks ago

…e was found in the database during the dup convert process.

What this PR does / why we need it:

Fixed the issue that a new output tag would not be uploaded if a cache was found in the database during the dup convert process.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #310

Please check the following list:

[ ] Does the affected code have corresponding tests, e.g. unit test, E2E test?
[ ] Does this change require a documentation update?
[ ] Does this introduce breaking changes that would require an announcement or bumping the major version?
[ ] Do all new files have an appropriate license header?

WaberZhuang commented 4 weeks ago

Thanks for the PR, please add your signature to the commit to pass the project check.

@estebanreyl Please take a look at this.

fourierrr commented 3 weeks ago

@estebanreyl sorry，i found my mistake yesterday night😂，and repush just now.

I found that your approach to the fix is similar to mine, but yours is more intuitive and elegant. I will close this PR.

estebanreyl commented 3 weeks ago

@fourierrr sounds good. Thanks again for the PR and opening the issue, I should've opened it up as soon as we were aware rather than waiting to avoid the double work. I'll try to do better in this regard moving forward. Anyway, I greatly appreciate your proactivity and contributions to the project. I will try to open a PR with my changes tomorrow, I think the changes are functional but need to add some testing and do some additional validation.

containerd / accelerated-container-image

Fixed the issue that a new output tag would not be uploaded if a cach… #311