search

contentful / marketplace-partner-apps

MIT License
9 stars 29 forks source link

[FlexFields] Markdown dialog not fully visible on smaller screen #983

Open JinHao-L opened 8 months ago

JinHao-L commented 8 months ago

Describe the bug Markdown dialog is not fully visible on smaller screen and cannot be scrolled

To Reproduce Steps to reproduce the behavior:

  1. Edit an entry with FlexFields editor & markdown field
  2. Change browser screen size to 1024x768
  3. Click on any markdown tool that opens a dialog (eg. Add link)
  4. If the dialog is long, the dialog content is cut-off & not scrollable

Expected behavior Allow scrolling for dialog

Screenshots Markdown dialog is not scrollable: 20240228-214512

In comparison, rich text dialog is scrollable and works fine 20240228-214604

JinHao-L commented 8 months ago

Not sure if useAutoResizer will be helpful here.

Ref: https://github.com/contentful/create-contentful-app/blob/master/packages/contentful--react-apps-toolkit/README.md#useautoresizer

whitelisab commented 8 months ago

Thanks for reporting this @JinHao-L! @vipulchadda, is this something that you can look into? Thank you!

vipulchadda commented 8 months ago

@whitelisab This looks like an issue with the default markdown field editor (we are using the default-field-editors to display the individual fields). I see the same behaviour in the field editors playground: https://contentful-field-editors.netlify.app/?path=/story/editors-markdown--default. Would you be able to help with that?

https://github.com/contentful/marketplace-partner-apps/assets/31496466/a0529abc-3aa8-4173-beb2-d47a86d22e65

whitelisab commented 8 months ago

Thank you for letting me know @vipulchadda, we will look into this and keep you posted.