search

conusio / conus

Other
0 stars 0 forks source link

images don't show up on all user-product pages #5

Closed elliottw closed 7 years ago

elliottw commented 7 years ago

image

http://conus.io/user/elliottw@gmail.com/Water%20rower

zlrth commented 7 years ago

oh man this was painful

http://conus.io/user/elliottw@gmail.com/Water%20rower doesn't work, but look at the space after "water rower" in the db:

{:id 12, :name "Water rower ", :description "", :askingprice "", :producturl "", :imageurl "/images/927528-conus-image.jpg", :email "elliottw@gmail.com", :timestamp #inst "2017-09-05T21:15:27.000000000-00:00"}

add a trailing %20 to the url, and it picture and other info should show up.

http://conus.io/user/elliottw@gmail.com/Water%20rower%20

zlrth commented 7 years ago

not sure about a fix yet. i'm open to ideas.

elliottw commented 7 years ago

jesus. that's ok. we just do some validation on the front end

On Tue, Sep 5, 2017 at 6:24 PM, matthew marks notifications@github.com wrote:

not sure about a fix yet. i'm open to ideas.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/conusio/conus/issues/5#issuecomment-327320770, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjrST4na39DZdlpiYwo9l4Yi4usQ3uBks5sfcoIgaJpZM4PNigT .

zlrth commented 7 years ago

fixed: https://github.com/conusio/conus/commit/12c17a31cf92a4f2ebd19f8a05334db5c45e9f01