remove `{SPECIAL_NOTES}`

[cooljeanius]

they're deprecated

(personally I wish wmllint could remove them for me, but according to wesnoth/wesnoth#6403, apparently a warning from wmlscope is all we're going to get)

[jgerrish]

If you're still looking for help with this, I wouldn't mind taking a look. I've been messing with Wesnoth lately and used to do Lua work with WoW, so I've been looking for a small task to contribute to.

Even if you're already in the process of fixing this, I just wanted to say thanks for the mod, code and being welcoming to new developers. It's a nice act and it's appreciated.

[cooljeanius]

So, 23acd73 got most of them, I just have to remove the custom {SPECIAL_NOTES} macros that this campaign defines for itself now... which also means removing the # wmllint: match {ABILITY} with {NOTE} comments so that wmllint stops trying to put them back in.

[jgerrish]

I can't help with this, I'm sorry. Sounds like you're running things fine.

[cooljeanius]

I can't help with this, I'm sorry. Sounds like you're running things fine.

oh ok well thanks for the offer anyways then!

[cooljeanius]

So @MadMax3947 is fixing this with 4e73846; I'm going to keep this assigned to myself for now, though, since it's up to me to merge it...

[cooljeanius]

Should be fixed on the 1.17 branch as of 02231e1

[cooljeanius]

leaving this open until I merge the 1.17 branch back to master

[cooljeanius]

cross-referencing this against wesnoth/wesnoth#6403, as I have an unanswered question there that's relevant to this issue

[cooljeanius]

31 should close this when merged (assuming we can resolve the merge conflicts properly)