1.18 branch - Githubissues

cooljeanius / Flight_Freedom

A Wesnoth drake campaign, originally by MadMax

https://forums.wesnoth.org/viewtopic.php?f=8&t=1887

GNU General Public License v2.0

3 stars 1 forks source link

1.18 branch #22

Closed cooljeanius closed 3 weeks ago

cooljeanius commented 3 weeks ago

WIP

cooljeanius commented 3 weeks ago

So, 2 possible options for the image optimization check:

try optimizing them more manually, or
increase the allowed threshold in the workflow from 45 to 55

I'm going to try the first one first...

MadMax3947 commented 3 weeks ago

So, 2 possible options for the image optimization check:
* try optimizing them more manually, or

* increase the allowed threshold in the workflow from 45 to 55
I'm going to try the first one first...

Removed EXIF data from a couple of the PNGs which should bring these images within the optimization threshold.

cooljeanius commented 3 weeks ago

So, 2 possible options for the image optimization check:
* try optimizing them more manually, or

* increase the allowed threshold in the workflow from 45 to 55
I'm going to try the first one first...
Removed EXIF data from a couple of the PNGs which should bring these images within the optimization threshold.

Can you add me as a collaborator on your fork so that I can push to this PR? I forgot to check the "Allow edits from maintainers" box when creating this PR...

cooljeanius commented 3 weeks ago

ok, so checks are all green now... I'll still want to give the changes a bit more of a manual look-over before merging...

cooljeanius commented 3 weeks ago

Attaching a zipfile of test saves for B branch testing: test_saves.zip

cooljeanius commented 3 weeks ago

looking through the attached saves, I see that there's one for each of the 7 playable scenarios in the B branch, which I'll take to imply adequate testing coverage, which ought to be enough for me to merge this

cooljeanius commented 3 weeks ago

Oh wait, I meant to get #24 done before merging this... oh well...