search

coopdigital / coop-frontend

Co-op CSS Foundations and design system mono-repo
MIT License
0 stars 0 forks source link

Add autocomplete attribute to Postcode component's postcode input #433

Closed philwolstenholme closed 2 years ago

philwolstenholme commented 2 years ago

I noticed we aren't providing an example of using an autocomplete attribute on the Postcode search component.

This is a super small change (my first Github PR since joining the Co-op last week 🥳) but using autocomplete helps meet WCAG 1.3.5: Identify Input Purpose and it reduces friction for customers too.

Before: image

After: image

I've made the markup changes but not sure what needs to happen next (after reviewing) to release and deploy the change.

mchadwickweb commented 2 years ago

Hey @philwolstenholme change looks good to me. I can take you through the current process to update the package version and then publish to NPM.

Essentially you jump back onto master and pull down the changes, then follow these steps

https://github.com/coopdigital/coop-frontend/blob/master/packages/README.md#publishing-new-versions