Closed philwolstenholme closed 2 years ago
Hey @philwolstenholme change looks good to me. I can take you through the current process to update the package version and then publish to NPM.
Essentially you jump back onto master and pull down the changes, then follow these steps
https://github.com/coopdigital/coop-frontend/blob/master/packages/README.md#publishing-new-versions
I noticed we aren't providing an example of using an
autocomplete
attribute on the Postcode search component.This is a super small change (my first Github PR since joining the Co-op last week 🥳) but using
autocomplete
helps meet WCAG 1.3.5: Identify Input Purpose and it reduces friction for customers too.Before:![image](https://user-images.githubusercontent.com/6339853/139029711-162f8107-2ef7-4911-8081-0a1833b4e143.png)
After:![image](https://user-images.githubusercontent.com/6339853/139029684-732ca299-87e7-474f-8e1c-8aed1f6d53da.png)
I've made the markup changes but not sure what needs to happen next (after reviewing) to release and deploy the change.