search

copilot-emacs / copilot.el

An unofficial Copilot plugin for Emacs.
MIT License
1.79k stars 126 forks source link

print warning message when copilot finds no mode-specific offset #191

Closed ultronozm closed 12 months ago

ultronozm commented 12 months ago

See https://github.com/zerolfx/copilot.el/issues/179. This is my best attempt to implement the suggestion made in the comment https://github.com/zerolfx/copilot.el/issues/179#issuecomment-1710276275.

blahgeek commented 11 months ago

Similar to https://github.com/zerolfx/copilot.el/pull/198, I think we should not invent our own "warning suppression" method.

ultronozm commented 10 months ago

I agree with your suggestion, and wasn't aware of the standard way to communicate warnings. Thanks! (As far as I'm concerned, please feel free to PR this if you know how to do it the right way)

On Mon, Oct 30, 2023 at 6:49 AM Yikai Zhao @.***> wrote:

Similar to #198 https://github.com/zerolfx/copilot.el/pull/198, I think we should not invent our own "warning suppression" method.

— Reply to this email directly, view it on GitHub https://github.com/zerolfx/copilot.el/pull/191#issuecomment-1784524787, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC5ZXJHNJT7VR3NZIVKMK3YB45VTAVCNFSM6AAAAAA5ZZRTHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGUZDINZYG4 . You are receiving this because you authored the thread.Message ID: @.***>

blahgeek commented 10 months ago

Though I'm not sure if it's ok to simply remove the copilot-indent-warning-suppress option since it's a "public" option that is already in master? Or do we need some deprecation process?

ultronozm commented 9 months ago

Given that I both reported the issue and submitted the fix, I would guess that not too many people are using this setting, so you shouldn't worry too much about having to properly deprecate it.