search

copilot-emacs / copilot.el

An unofficial Copilot plugin for Emacs.
MIT License
1.79k stars 126 forks source link

Catching copilot.vim v1.12.1 up #207

Closed rakotomandimby closed 10 months ago

rakotomandimby commented 10 months ago

Attempt to resolve https://github.com/zerolfx/copilot.el/issues/205

csheaff commented 10 months ago

what about using a git submodule? i would feel a lot more comfortable using this repo if the binary was directly pulled from https://github.com/github/copilot.vim

rakotomandimby commented 10 months ago

@csheaff , You are right, submodule would be a good solution. But I think we just use the dist/* subfolder of upstream repo, not the whole one. Plus, @zerolfx is not confident about compatibility: upstream can break API.

zerolfx commented 10 months ago

updated by bot b8a32ff6b9757a84320da003eeb672036d49d91e

Thanks for testing the plugin with the latest upstream.

csheaff commented 10 months ago

@rakotomandimby thanks for the response. I suppose I'll just compare the hashes of the binaries with the official ones.

zerolfx commented 10 months ago

@csheaff Thanks for your suggestion. The primary reason I don't use git submodule is to avoid complicating the package installation process, especially with those different package managers.