search

copilot-emacs / copilot.el

An unofficial Copilot plugin for Emacs.
MIT License
1.71k stars 122 forks source link

JSONRPC: ‘:events-buffer-scrollback-size’ deprecated. Use ‘events-buffer-config’. #225

Closed ethan-leba closed 5 months ago

ethan-leba commented 6 months ago

As of https://github.com/emacs-mirror/emacs/commit/e0b9944b69ff72923c29756fcfcea9528a3f5069, this line will emit a warning: https://github.com/zerolfx/copilot.el/blob/653fe7b12990b5b7a050971bed4579022ce4b4f8/copilot.el#L157

Unfortunately events-buffer-config was added in the same commit events-buffer-scrollback-size was deprecated, so it's not a trivially easy fix. Maybe checking if the events-buffer-config slot is present on jsonrpc-process-connection would be decent fix?

ethan-leba commented 6 months ago

Oops, should've checked the PR tab first: #224

emil-vdw commented 5 months ago

Fixed by #224