Use error handling to deal with older jsonrpc

copilot-emacs / copilot.el

An unofficial Copilot plugin for Emacs.

MIT License

1.79k stars 126 forks source link

Use error handling to deal with older jsonrpc #264

Closed jkl1337 closed 7 months ago

jkl1337 commented 7 months ago

jsonrpc :events-buffer-scrollback-size slot is deprecated. Try using the new slot (:events-buffer-config) and fallback to the old way if that fails.

I think this is a cleaner approach than trying to deal with emacs package metadata. Fixes #261 and fixes #262.

jcs090218 commented 7 months ago

Can you fix the version in the header?

- ;; Package-Requires: ((emacs "27.2") (s "1.12.0") (dash "2.19.1") (editorconfig "0.8.2") (jsonrpc "1.0.23"))
+ ;; Package-Requires: ((emacs "27.2") (s "1.12.0") (dash "2.19.1") (editorconfig "0.8.2") (jsonrpc "1.0.14"))

Thanks!