Version is hardcoded to empty string

core-api / python-openapi-codec

An OpenAPI codec for Core API.

Other

33 stars 35 forks source link

Version is hardcoded to empty string #40

Open tovmeod opened 7 years ago

tovmeod commented 7 years ago

file encode.py it fills the versions like this:

swagger['info']['version'] = ''

it should be able to get the version info properly. I ended up writing my own decoder just to fill the version

tomchristie commented 7 years ago

The Core API document doesn't currently have version metadata, so not something we can address immediately.

tovmeod commented 7 years ago

Until they do this could be pulled from settings, and from OpenAPIRenderer attribute, if I wish to set the version I could either use settings or subclass OpenAPIRenderer, since I am already sublassing to implement get_customizations().

Also basepath could be set in the same way