search

corowne / lorekeeper

A dA ARPG masterlist framework
MIT License
111 stars 122 forks source link

Shop Features on Develop? #1094

Open SpeedyD opened 2 hours ago

SpeedyD commented 2 hours ago

This has kinda been a long time coming, and I'm not sure why I'm starting this discussion right now, in here, but..

I sincerely think that @ScuffedNewt's Shop Features extension (https://github.com/ScuffedNewt/lorekeeper/tree/extension/shop-features) should be part of v3. Or, at this point, v3.1 I guess.

It's got a lot of features which, in my personal opinion, should've been part of core ages ago, and despite that I've asked and suggested this before, it has yet to happen.. Hence this discussion thread.. issue.. whatever.

Let's just get this implemented into Dev. It needs to be a Core Ext, and you know it.

itinerare commented 2 hours ago

Yeah, it's been in discussion for some time.

ScuffedNewt commented 2 hours ago

As much as I agree, shop features are waiting on some updates/changes I haven't made that will fundamentally modify how shops work. Until this is complete, I don't think it's worth the effort to merge since it also restricts my own ability to work on it

Shop features is definitely one of the extensions that are possibly seen as a "must" on a new install, but its not ready to be core yet