Open jamesgolabek22 opened 3 hours ago
@jamesgolabek22 thank you! I understand the issue. The change from landscape()
to pl_new()
did not affect the internals of the function, so the same limitations on its use still apply.
This is something that should be addressed before submission to CRAN, so i will leave this issue open for the time being. Specifically, if a user provides a numeric matrix to pl_new()
, the function should be able to determine whether it contains only birth/death values (in which case degree
should indicate the dimensions of the features) or dimension values as well (in which case degree
should specify the dimension to use). Hopefully this won't have counterintuitive aftereffects; it seems natural enough behavior, and would require the input matrix to have either 2 or 3 columns, which should limit ambiguity.
This issue is similar to issue #3, opened by @a1danbryant .
I reinstalled {plt} from the new branch, so that
pl_new()
could be utilized. My understanding wasas_persistence()
would not need to be explicitly called since 1) the naming conflict was resolved, and 2)as_persistence()
is called inpl_new()
.Below is an example of the difference of the persistence landscape plots for when we use
as_persistence()
and when we do not.