search

cosmicds / blaze-star-nova

MIT License
0 stars 4 forks source link

Adjustments for small screens #36

Closed johnarban closed 2 months ago

johnarban commented 2 months ago

Allow time display to be customized a bit more. We can optionally show the date/timezone, we can also use a short-time-date prop. What happens is clearer than with the smAndDown prop. Also slightly offsets the mouse icon to look more 'over the button' than 'in the button'

image image
patudom commented 2 months ago

Something about this breaks the middle "show me what the nova will look like" button on mobile. It takes you to the T CrB location, but it does not switch the layer btw Tycho & USNO. @johnarban or @Carifio24 can one of you please take a look?

This is otherwise a much improved small screen layout!

johnarban commented 2 months ago

Yes, that was an intentional change - I thought i put a note, but I needed to remove the button which toggles the tycho layer in order to make things fit properly. There wasn't enough space for all 3 large buttons, especially when the 'T CrB is Set' chip is visible. It is gone only for very small landscape screens ( < 330 px)

patudom commented 2 months ago

So for me, the button is visible, but it doesn't behave how it should. You can press it, and it will take you to T CrB if it wasn't already centered on it, but the layer views don't change. I see why we'd want to get rid of the button all together for small screens, but we don't want a visible but non-working button.

patudom commented 2 months ago

Not sure why, but this PR seems to be working correctly on my phone now. I will try to merge the conflicts locally and check it again. If it's still working I'll assume the non-working button was a weird blip and mark this to merge.