cosmicds / hubbleds

Hubble's law data story
MIT License
0 stars 8 forks source link

remaining WWT issues in solara update #346

Closed patudom closed 2 weeks ago

patudom commented 9 months ago
johnarban commented 9 months ago

@Carifio24 These should be fixed on https://github.com/nmearl/hubbleds/pull/1 in conjunction with https://github.com/nmearl/ipywwt/pull/4 on @nmearl's branch. These don't use the solara app, but the issues are present in the jupyter version too and stemmed from ipywwt

Carifio24 commented 9 months ago

In my testing this all worked well, I didn't see any issues. The only concern that I have is whether or not it's possible for the message from the mounted hook to be emitted before the Python handler is set up. My hunch is that this won't happen, but I couldn't convince myself that it's impossible.

I might try and set up a ping-pong message based version of this, mostly since the fewer deviations we have from the upstream research app the easier the easier this will be to integrate later on. But I think this is fine for now.