search

cosmicds / hubbleds

Hubble's law data story
MIT License
0 stars 8 forks source link

Restore WWT nudges in intro slideshow #611

Closed Carifio24 closed 2 weeks ago

Carifio24 commented 2 weeks ago

This PR fixes #603. I took the duration to wait before nudging (which is 2 minutes, in ms), from the voila version. All of this was handled Python-side in the old setup, but since we're using setTimeout client-side to do the timing, I just moved all of the logic into the Vue template as we only need to store a few different values.

Note that this is still Vue 2, so to update an array reactively we need to use this.$set.

patudom commented 2 weeks ago

@johnarban, I adjusted the nudge values and wanted to see if you think what I put in was reasonable. The original value was 2 minutes for each slide, but using the audio reader on the default speed takes almost a full minute for some of the text, so I figured if someone were trying to read all the text before they explore, that would only give them ~a minute to explore. I made the first slide length longer for people who really get into it, but we can change it if you think that's too much time total for the intro.