search

cosmicds / vue-toolkit

Vue-based toolkit for creating Cosmic Data Stories using WorldWide Telescope
https://www.npmjs.com/package/@cosmicds/vue-toolkit
MIT License
0 stars 4 forks source link

change the color/shadowing when icon buttons are active #17

Closed heywooddogwood closed 1 month ago

Carifio24 commented 1 month ago

My only comment would be that if we're not going to use the box shadow (which I'm totally fine with), we should update the component props and typing to reflect that. The prop type JSDoc comments get used to automatically generate the Storybook descriptions, so we should have them be up-to-date. (I'm happy to do this stuff if you want!)

patudom commented 1 month ago

@Carifio24, can you please give this a quick look and make sure it's ok?

One thing I noticed is that modelValue, faIcon, mdiIcon, and tooltipText are not in the list of props in the IconButton.vue file - should they be?

Thanks!

Carifio24 commented 1 month ago

@patudom It's fine that they aren't there - the object defined inside the withDefaults macro is just giving the default values for these props, but we don't have natural defaults for the icon and tooltip text so they're omitted.