search

cosmir / openmic-annotator

Annotation framework for annotating data for OpenMIC
MIT License
56 stars 1 forks source link

Ejh 20160829 backend issue10 #15

Closed ejhumphrey closed 8 years ago

ejhumphrey commented 8 years ago

Will close #10, introduces a basic flask app with some minimal endpoints to start unblocking other facets of the project, plus tests and half of #3.

This change is Reviewable

ejhumphrey commented 8 years ago

now it's clear to be merged. I'd defer to @bmcfee or @cjacoby as resident py3 compliance experts, but anyone else is welcome to chime in.

ejhumphrey commented 8 years ago

Having trouble refreshing repos on coveralls, bailing for the evening ... hopefully these changes will propagate tomorrow and we can close out both #3 and #10 in this PR.

stefan-balke commented 8 years ago

Great!

Since this is the first PR, could you add reviewable for CR to the stack?

Thanks!

stefan-balke commented 8 years ago

I understand that it might be helpful to run everything with the GoogleSDK from the beginning, but couldn't we have some

if __name__ == '__main__':
    app.run(debug=True)
stefan-balke commented 8 years ago

I tested the three endpoints with the local Flask server. LGTM so far.

ejhumphrey commented 8 years ago

Added reviewable and the if main check ... still not sure what's going on with coveralls, but (a) this project still doesn't show and (b) attempting to "sync repos" spins indefinitely. maybe I'm doing it wrong, but I don't think this is a blocker just yet.