Ejh 20160901 issue7 -- Backend Server basics

cosmir / openmic-annotator

Annotation framework for annotating data for OpenMIC

MIT License

56 stars 1 forks source link

Ejh 20160901 issue7 -- Backend Server basics #25

Closed ejhumphrey closed 7 years ago

ejhumphrey commented 7 years ago

Will close #7, implements a bunch of good stuff

audio upload endpoint
audio download endpoint
polymorphic local variants of gcloud's classes
common interface for swapping gcloud / local backends
test coverage for library tools and main server

This change is

coveralls commented 7 years ago

Changes Unknown when pulling e0ff32e0a9c5f4ee8968331666f64f216aa8603c on ejh_20160901_issue7 into on master.

ejhumphrey commented 7 years ago

alright, now I think this is ready to be merged. @bmcfee can I trouble you check off the remaining open discussions?

ejhumphrey commented 7 years ago

backend_server/tests/test_main.py, line 28 at r4 (raw file):

Previously, ejhumphrey (Eric J. Humphrey) wrote…

Done.

okay, there was actually a bug here, so, hurrah testing! now uploads happen by posting to /audio. Before, the endpoint was treating upload as a track URI in the getter, so it wasn't behaving as expected.

Comments from Reviewable

bmcfee commented 7 years ago

Reviewed 2 of 4 files at r7, 6 of 6 files at r8. Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable