Making the demo slightly easier to use

cosmir / openmic-annotator

Annotation framework for annotating data for OpenMIC

MIT License

56 stars 1 forks source link

Making the demo slightly easier to use #44

Closed urinieto closed 7 years ago

urinieto commented 7 years ago

I have added the following to the demo script:

Argparse, parametrizing the two main ports (server and webapp).
Allow for Ctrl-C to shutdown the server (it was really annoying to press Ctrl-C and still have the server running).
Some checks so that it is easier for newcomers to know that:
1. the script must be launched from the root folder
2. the submodules are needed to run the demo
Docstrings.

coveralls commented 7 years ago

Coverage decreased (-1.4%) to 89.474% when pulling ae6ba2de8b16a540067678943c450ec7bebbe801 on argparse-demo into 969a3b7ffcb81b3111d12c948dca3f8bfd893684 on master.

coveralls commented 7 years ago

Coverage decreased (-1.4%) to 89.474% when pulling ae6ba2de8b16a540067678943c450ec7bebbe801 on argparse-demo into 969a3b7ffcb81b3111d12c948dca3f8bfd893684 on master.

ejhumphrey commented 7 years ago

looks solid! I'm not too concerned about the drop in code coverage, since I don't think this can run on Travis.... but would gladly be re-educated in these matters.

coveralls commented 7 years ago

Coverage decreased (-1.4%) to 89.474% when pulling 4e3cd54fd6d2afbe050a169bf4f4c8fb6f09b327 on argparse-demo into 969a3b7ffcb81b3111d12c948dca3f8bfd893684 on master.

urinieto commented 7 years ago

Not sure where the comment about AssertionError -> EnvironmentError is, but I updated the code in 4e3cd54. Also yea, I'm not too concerned about the Coveralls decrease either.

Thanks for the review!