cpanse / protViz

Visualizing and Analyzing Mass Spectrometry Related Data in Proteomics
https://CRAN.R-project.org/package=protViz
GNU General Public License v3.0
11 stars 3 forks source link

template<class _Arg1, class _Arg2, class _Result> struct std::binary_function’ is deprecated #16

Closed cpanse closed 2 years ago

cpanse commented 2 years ago

https://github.com/cpanse/protViz/blob/e4a1f7d0e3382f5d9ffccc3c48a790ae1f2b5166/src/findNN_.cpp#L51

Screenshot 2022-03-15 at 21 48 48

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_protViz.html.

Specifically, please see the installation warnings for r-devel-linux-x86_64-debian-gcc: these can be reproduced by using a current snapshot of the GCC 12 toolchain.

GCC 12 adds new warnings for use of C++ standard library features that are deprecated (or no longer present at all) in recent C++ standards, including std::unary_function and std::binary_function.

See "C++ Standard Library deprecations" in https://gcc.gnu.org/gcc-12/porting_to.html for more information.

Can you please fix as necessary?

Please correct before 2022-03-29 to safely retain your package on CRAN.

Best, -k

cpanse commented 2 years ago

used the following Dockerfile for reproducing the g++-12 warning

FROM debian:unstable

MAINTAINER Christian Panse <Christian.Panse@gmail.com>

RUN apt-get update \
  && apt-get install vim less unzip r-base -y 

RUN apt-get install gcc-12 g++-12 -y

ADD install.R /tmp
RUN R --no-save < /tmp/install.R

# RUN apt-get install clang-14 -y
RUN cat /etc/debian_version 
RUN gcc-12 -v