cpuguy83 / containerd-shim-systemd-v1

Apache License 2.0
57 stars 2 forks source link

Fix tty handler error reporting #6

Open cpuguy83 opened 1 year ago

cpuguy83 commented 1 year ago

The way errors are sent from the tty handler does not really work. The wire format was supposed to be [sizeof(msg)][msg], however this was never implemented correctly and even had some compiler warnings (depending on what version/compiler was used).

Right now it is just writing the raw message to the socket... this can work if we close the connection down and then can just read to EOF... but I don't really like this.