createdotnet / API-Documentation

Create. API Documenation
http://developers.create.net/API-Documentation/
0 stars 2 forks source link

Problem with paging? #6

Closed robertoldaker closed 9 years ago

robertoldaker commented 9 years ago

I cannot get the paging to work. When I set the "per_page" to 50 or 100 I am always getting back 25 values. If I set "last_id" to the last item of a previous returned set of products it still returns the original set of products.

This could be related to the caching issue (5) but I did add a "random" query value to force caching off.

Dayjo commented 9 years ago

Hi Rob,

Thanks for spotting this, this is definitely reproducible.

Dayjo commented 9 years ago

This has now been fixed, both per_page and last_id should work as expected!

Note: when using last_id, the specified ID will not be included in the result set. Also, per_page is currently limited to 100.

robertoldaker commented 9 years ago

Yes - I can they work now (btw. max appears to be 99 not 100!)

On 16 January 2015 at 15:27, Joel notifications@github.com wrote:

Closed #6 https://github.com/createdotnet/API-Documentation/issues/6.

— Reply to this email directly or view it on GitHub https://github.com/createdotnet/API-Documentation/issues/6#event-220130605 .

Dayjo commented 9 years ago

Hi Rob,

Which command are you using and getting 99 instead of 100?

robertoldaker commented 9 years ago

"products" using the token starting "8c3c1 ..." (this account has a few hundred products)

Rob.

On 16 January 2015 at 15:42, Joel notifications@github.com wrote:

Hi Rob,

Which command are you using and getting 99 instead of 100?

— Reply to this email directly or view it on GitHub https://github.com/createdotnet/API-Documentation/issues/6#issuecomment-70271593 .

Dayjo commented 9 years ago

Hi Rob,

Have seen why this is and fix is ready to go live on Monday.

Dayjo commented 9 years ago

This has gone live, 100 should now return 100.

robertoldaker commented 9 years ago

Works for me now!

On 19 January 2015 at 11:02, Joel notifications@github.com wrote:

This has gone live, 100 should now return 100.

— Reply to this email directly or view it on GitHub https://github.com/createdotnet/API-Documentation/issues/6#issuecomment-70476763 .