search

crflynn / stochastic

Generate realizations of stochastic processes in python.
http://stochastic.readthedocs.io/en/stable/
MIT License
451 stars 80 forks source link

Mixed Poisson Process #8

Closed Gabinou closed 6 years ago

Gabinou commented 6 years ago

Hello,

As suggested, I have removed general messyness and included proposed feature into independent branches, starting with the simplest: the mixed poisson process.

Is this branch more suitable?

crflynn commented 6 years ago

See my comment in #7

Looks like you have deleted some test fixtures? That's why the tests are failing on travis.

crflynn commented 6 years ago

Are you not able to run the tests locally?

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@bd46a66). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##             dev     #8   +/-   ##
====================================
  Coverage       ?   100%           
====================================
  Files          ?     35           
  Lines          ?   1226           
  Branches       ?      0           
====================================
  Hits           ?   1226           
  Misses         ?      0           
  Partials       ?      0
Impacted Files Coverage Δ
stochastic/continuous/mixed_poisson.py 100% <100%> (ø)
stochastic/continuous/__init__.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd46a66...101c0ad. Read the comment docs.

Gabinou commented 6 years ago

Indeed I couldn't... but now I can! The tests are passing now.

crflynn commented 6 years ago

Cool. I'll review again when I have some extra time. Thanks for addressing the changes.