cronos-labs / play-cpp-sdk

Generate wallet, Fetching transaction history, Transfer token, WalletConnect, Crypto.com Pay, and more
Other
16 stars 5 forks source link

Problem: Missing support different json_rpc_method for ERC20/721/1155 related methods (fix #427) #428

Closed damoncro closed 1 year ago

damoncro commented 1 year ago

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

Thank you for your code, it's appreciated! :)

codecov-commenter commented 1 year ago

Codecov Report

Merging #428 (e7296ac) into main (d35ffd8) will increase coverage by 0.41%. The diff coverage is 0.00%.

:mega: This organization is not using Codecovโ€™s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   24.00%   24.41%   +0.41%     
==========================================
  Files          25       25              
  Lines        3087     3035      -52     
==========================================
  Hits          741      741              
+ Misses       2346     2294      -52     
Impacted Files Coverage ฮ”
extra-cpp-bindings/src/lib.rs 20.23% <0.00%> (+0.33%) :arrow_up:
extra-cpp-bindings/src/walletconnect.rs 0.00% <0.00%> (รธ)

:mega: Weโ€™re building smart automated test selection to slash your CI/CD build times. Learn more