cronos-labs / play-cpp-sdk

Generate wallet, Fetching transaction history, Transfer token, WalletConnect, Crypto.com Pay, and more
Other
16 stars 5 forks source link

Problem: not exposing c++ api for wc 2.0 sign , send tx (fix #453) #454

Closed leejw51crypto closed 1 year ago

leejw51crypto commented 1 year ago

expose c++ api for wc 2.0 sign, send tx

leejw51crypto commented 1 year ago

ci test fails, fixing now

leejw51crypto commented 1 year ago

rust linting rule changed, inspecting now

codecov-commenter commented 1 year ago

Codecov Report

Merging #454 (12cba4a) into main (0f5e0bc) will decrease coverage by 1.82%. The diff coverage is 0.00%.

:exclamation: Current head 12cba4a differs from pull request most recent head e64117b. Consider uploading reports for the commit e64117b to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   20.90%   19.09%   -1.82%     
==========================================
  Files          26       26              
  Lines        3544     3881     +337     
==========================================
  Hits          741      741              
- Misses       2803     3140     +337     
Impacted Files Coverage Δ
extra-cpp-bindings/src/lib.rs 17.06% <0.00%> (-0.28%) :arrow_down:
extra-cpp-bindings/src/walletconnect.rs 0.00% <0.00%> (ø)
extra-cpp-bindings/src/walletconnect2.rs 0.00% <0.00%> (ø)
wallet-connect/src/v2/client.rs 0.00% <0.00%> (ø)
wallet-connect/src/v2/protocol.rs 48.68% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

leejw51crypto commented 1 year ago

working on comments