search

crossplane-contrib / provider-kafka

Crossplane provider for Kafka
Apache License 2.0
30 stars 32 forks source link

Support to Add, Remove and List ACLs (Fixes #6) #26

Closed jograca closed 2 years ago

jograca commented 2 years ago

Description of your changes

This Pull Request adds feature complete ACL support to Add, Remove and List ACLs. Fixes #6

I have:

How has this code been tested

Automated tests are forthcoming

1) Created an ACL by applying examples/acl/acl.yaml 2) Verified by running kcl admin acl describe --type any --pattern match --op any --perm any 3) Updated ACL by changing a Principle in examples/acl/acl.yml 4) Applied the ACL and noticed the Update threw an error 3) Deleted ACL by deleting examples/acl/acl.yaml 4) Verified by same process as bullet 2

jograca commented 2 years ago

Hope we have an MVP solution for Updates here @turkenh. We do a reconcile at Late Initialize. Would like your thoughts

turkenh commented 2 years ago

Hope we have an MVP solution for Updates here @turkenh. We do a reconcile at Late Initialize. Would like your thoughts

@jograca Any other questions than late init which I commented above?

elohmrow commented 2 years ago

🎉

turkenh commented 2 years ago

🙌