Closed rtoma closed 2 years ago
My stab at adding mTLS support, re https://github.com/crossplane-contrib/provider-kafka/issues/37
Tested with AWS MSK, using this ProviderConfig credential Secret:
{ "brokers": [ "b-1.redacted.kafka.eu-central-1.amazonaws.com:9094", "b-2.redacted.kafka.eu-central-1.amazonaws.com:9094", "b-3.redacted.kafka.eu-central-1.amazonaws.com:9094" ], "tls": { "clientCertificateSecretRef": { "name": "my-client-cert", "namespace": "some-ns" } } }
Where clientCertificateSecretRef references a TLS Secret by name and namespace. The Secret keys used match the TLS definition, as used by cert-manager.
clientCertificateSecretRef
I have:
make reviewable test
Description of your changes
My stab at adding mTLS support, re https://github.com/crossplane-contrib/provider-kafka/issues/37
Tested with AWS MSK, using this ProviderConfig credential Secret:
Where
clientCertificateSecretRef
references a TLS Secret by name and namespace. The Secret keys used match the TLS definition, as used by cert-manager.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested