search

crossplane-contrib / provider-kafka

Crossplane provider for Kafka
Apache License 2.0
30 stars 33 forks source link

ArgoCD-Crossplane: Topic finalizer prevents deletion #48

Closed withoutnickname closed 1 year ago

withoutnickname commented 2 years ago

Hi team,

Is there a way to override/remove Topic default finalizer (finalizer.managedresource.crossplane.io) declaratively?

The use-case: ArgoCD cannot remove Topic object after manifest deletion in Git and synchronization never ends: image

If to remove finalizer from Topic's spec manually - all goes as expected immediately.

Already tried:

metadata:
  finalizers:
    - resources-finalizer.argocd.argoproj.io

and

metadata:
  finalizers: []

but no luck, finalizer.managedresource.crossplane.io finalizer is still added automatically.

crossplane:v1.9.1 provider-kafka-controller:v0.1.0 argocd:v2.4.12

jograca commented 1 year ago

This is largely an Argo issue, not for this provider. @withoutnickname contact me and I think we can get to a resolution.

admssa commented 1 year ago

@withoutnickname any luck in removing topics w/o patching it?