Feat: Add support for controlling spillover

cryptk commented 1 year ago

This was split off from #63

related issue to add API support: https://github.com/cryptk/python-omnilogic-local/issues/42

cryptk commented 1 year ago

API support for SetUISpilloverCmd is in, just need a pcap example of spillover being disabled, the enable command doesn't have an on/off parameter, so I'm not sure how to disable spillover once it's been enabled.

madasus commented 1 year ago

@cryptk can you elaborate on what you need and i'll capture whatever logs are needed

madasus commented 1 year ago

@cryptk Bumping for information.

cryptk commented 1 year ago

@madasus I think I have what I need, it's just a matter of finding the time. My kids go back to school in a couple of weeks and I should have time then to work on getting a lot of these feature requests finished up.

cryptk commented 1 year ago

This is finally in development and currently undergoing testing and refinement. A new version with this support should be available soon

madasus commented 11 months ago

That’s great . I am looking forward to testing. Our pool is closed for winter but will be open in spring

irlkitcom commented 10 months ago

I see a commit for partial spillover support, has it been enabled? I'm not seeing it in HA. I'd love to get everything my pool supports into HA.

cryptk commented 10 months ago

@irlkitcom if you select redownload from HACS for the integration and flip the switch to show beta versions, you should be able to install the version "main" and start testing it out today

cryptk commented 10 months ago

@irlkitcom and @madasus I just tagged version 0.7.0, that includes the initial spillover support. Give it a try and let me know what you think. It might need some behavior adjustments around how it handles the pump speed when you toggle spillover on and off, but I don't have a pool with spillover to test with, so feedback is very welcome!

clintforester commented 10 months ago

Mine turns on and always goes to 2587 RPM. If I try to change the pump speed it turns off the spillway but the pump changes speed. If I turn the spillover off it turns off the pump and spillway. Obviously we can get around this with automations. Just giving an update from my end

irlkitcom commented 10 months ago

@irlkitcom and @madasus I just tagged version 0.7.0, that includes the initial spillover support. Give it a try and let me know what you think. It might need some behavior adjustments around how it handles the pump speed when you toggle spillover on and off, but I don't have a pool with spillover to test with, so feedback is very welcome!

I only briefly tested it, it seemed to work just fine, I appreciate your work on this!

EDIT: I did notice the pump speed changed once I turned it on/off. I will have to test further.

madasus commented 10 months ago

Thank you. Our pool is closed for the winter. Once we open it again in spring i'll report back!

madasus commented 5 months ago

Hi - Finally we are open for the season.

The spillover function does seem to work but with a strange quirk. When I set the spillover to enable it always sets the pump speed to 75%. If I change the pump speed it turns the spillover off.

Any thoughts? What information can I provide to help debug?

krucka commented 3 months ago

I'm having this same issue, with pool and spa on shared equipment (same variable speed pump operates pool and spa and the pause for valve change setting enabled). In addition to what's already been posted above, here are some things I've noticed in:

the Hayward app:

Speed starts out at 100% during "priming" and stays at 100% once priming complete when started from Hayward app or pre-programmed schedule
Entities such as a spa blower just have on/off, like a switch.
With spillover "on", the pool pump shows "on" and spa pump shows "off - in pool/spillover mode"
The spillover has it's own speed setting that matches the pool pump speed. Changing speed in one also changes it in the other, but spa always remains "off"

homeassistant:

Similar to above, speed starts out at 100% during "priming" but drops to 75% once priming complete when started from homeassistant
Pool and spa show up as two separate pump entities, each with their own on/off and speed.
Spillover appears as a switch rather than another pump.
When adjusting the speed back to 100% changes the valves back to pool mode, no spillover
Maybe we could check the pump "why on" attribute when sending the pump speed command as when in spillover mode, this attribute is set to "Manual Spillover" and could not trigger a valve change to pool mode
Maybe the spillover just needs to be pulled in as another pump rather than a switch entity.

I'll try to grab the packets over wireshark at some point soon to try to further troubleshoot. If anyone has any further recommendations, let me know

cryptk / haomnilogic-local

Feat: Add support for controlling spillover #67