search

cryptk / haomnilogic-local

A Home Assistant integration for Hayward OmniLogic/OmniHub pool controllers using the local UDP api
Apache License 2.0
18 stars 4 forks source link

Feat: Add support for controlling spillover #67

Open cryptk opened 1 year ago

cryptk commented 1 year ago

This was split off from #63

related issue to add API support: https://github.com/cryptk/python-omnilogic-local/issues/42

cryptk commented 1 year ago

API support for SetUISpilloverCmd is in, just need a pcap example of spillover being disabled, the enable command doesn't have an on/off parameter, so I'm not sure how to disable spillover once it's been enabled.

madasus commented 1 year ago

@cryptk can you elaborate on what you need and i'll capture whatever logs are needed

madasus commented 11 months ago

@cryptk Bumping for information.

cryptk commented 11 months ago

@madasus I think I have what I need, it's just a matter of finding the time. My kids go back to school in a couple of weeks and I should have time then to work on getting a lot of these feature requests finished up.

cryptk commented 7 months ago

This is finally in development and currently undergoing testing and refinement. A new version with this support should be available soon

madasus commented 6 months ago

That’s great . I am looking forward to testing. Our pool is closed for winter but will be open in spring

irlkitcom commented 6 months ago

I see a commit for partial spillover support, has it been enabled? I'm not seeing it in HA. I'd love to get everything my pool supports into HA.

cryptk commented 6 months ago

@irlkitcom if you select redownload from HACS for the integration and flip the switch to show beta versions, you should be able to install the version "main" and start testing it out today

cryptk commented 6 months ago

@irlkitcom and @madasus I just tagged version 0.7.0, that includes the initial spillover support. Give it a try and let me know what you think. It might need some behavior adjustments around how it handles the pump speed when you toggle spillover on and off, but I don't have a pool with spillover to test with, so feedback is very welcome!

clintforester commented 5 months ago

Mine turns on and always goes to 2587 RPM. If I try to change the pump speed it turns off the spillway but the pump changes speed. If I turn the spillover off it turns off the pump and spillway. Obviously we can get around this with automations. Just giving an update from my end

irlkitcom commented 5 months ago

@irlkitcom and @madasus I just tagged version 0.7.0, that includes the initial spillover support. Give it a try and let me know what you think. It might need some behavior adjustments around how it handles the pump speed when you toggle spillover on and off, but I don't have a pool with spillover to test with, so feedback is very welcome!

I only briefly tested it, it seemed to work just fine, I appreciate your work on this!

EDIT: I did notice the pump speed changed once I turned it on/off. I will have to test further.

madasus commented 5 months ago

Thank you. Our pool is closed for the winter. Once we open it again in spring i'll report back!

madasus commented 1 month ago

Hi - Finally we are open for the season.

The spillover function does seem to work but with a strange quirk. When I set the spillover to enable it always sets the pump speed to 75%. If I change the pump speed it turns the spillover off.

Any thoughts? What information can I provide to help debug?