search

cucumber-attic / cuke4duke

Cucumber support for the JVM: Java, Scala, Groovy, Clojure, Ioke, Javascript, Spring, Guice, PicoContainer, WebDriver, Ant and Maven
http://wiki.github.com/aslakhellesoy/cuke4duke
MIT License
256 stars 72 forks source link

cuke4duke-maven-plugin is does not use username/password for proxy connection #112

Open imod opened 13 years ago

imod commented 13 years ago

If maven is configured to use a proxy, the cuke4duke maven plugin only uses protocol/host/port combination while triggering the gem installation. The plugin should add the username/password to the http-proxy argument too - otherwise the conenction to the outherworld fails!

e.g. if username/password is defined, it should not define the http-proxy like this: --http-proxy http://myproxy.com:8080 but like this: --http-proxy http://theuser:secret@myproxy.com:8080

imod commented 13 years ago

I send a pull request to fix this issue: https://github.com/cucumber/cuke4duke/pull/113

joelbyrnes commented 13 years ago

This is also an issue for my team. We'd appreciate the fix being pulled in. Thanks!