search

cuducos / my-internet-speed

🛎️ Monitor the speed your ISP is delivering
GNU General Public License v3.0
135 stars 13 forks source link

Cite @anatel if the percentage is smaller than 10%. #8

Closed diraol closed 6 years ago

diraol commented 6 years ago

FIX #7

cuducos commented 6 years ago

Hi @diraol – many thanks for the contribution and for the interest : )

Unfortunately I am not sure about this PR.

  1. I think the main reason I kept the tweet message as a configuration, not as part of the program itself – a strict separation of config from code – is so users decide what they are tweeting and whom they are tagging; and I wouldn't like to step out of this path.
  2. Adding explicitly ANATEL is a Brazilian thing and won't make sense elsewhere.
  3. AFAIK (and as far as it is documented) 10% is a rather arbitrary value (personally I like the idea of tagging ANATEL, but I would do it every time the ISP disrespects ANATEL's regulation (that is why it needs a variable MINIMUM_SPEED) and not only when it disrespects too much (because too much is too subjective indeed).
  4. Using general concepts such asMINIMUM_SPEED make the project independent of ANATEL or any country-specific regulations, making it reasonable for most countries of the world I guess.

I discuss it further (and some better concepts for implementation) in #7 though.