Forward ESC to evil-surround

cute-jumper / evil-embrace.el

Evil integration of embrace.el

50 stars 5 forks source link

Forward ESC to evil-surround #2

Closed hlissner closed 8 years ago

hlissner commented 8 years ago

I think it would be more sensible for ESC to abort the surround, rather than surround with ^['s. This can be fixed either by adding ?\C-\[ to evil-embrace-evil-surround-keys (evil-surround has an abort-on-esc fallback) or have evil-embrace itself handle escapes appropriately.

Great plugin, by the way!

cute-jumper commented 8 years ago

Thanks for the suggestion and nice words! For the time being, I think it is fine to just let evil-surround handle the ESC for evil-embrace. So I just passed the ESC to evil-surround. Let me know if there is any problem. Thanks!

casouri commented 6 years ago

Maybe update this change in README?

casouri commented 6 years ago

Maybe it's my problem, but could you try to reproduce this?

embrace-add -- ESC -- selection surrounded by ^[

All three package are installed and loaded, and I have ran evil-embrace-enable-evil-surround-integration.