cvut / qtrvsim

RISC-V CPU simulator for education purposes
GNU General Public License v3.0
473 stars 56 forks source link

Add CMake configuration option to select Qt5 or Qt6 #144

Closed Flowdalic closed 2 months ago

Flowdalic commented 2 months ago

Gentoo downstream here.

It would be great if there was a CMake configuration option to select Qt5 or Qt6 (probably defaulting to autoselect). This makes it easier to reliable package qtrvsim [1]. Right now, qtrvsim basically establishes an automagic dependency on Qt, which is problematic [2].

1: https://bugs.gentoo.org/933594 2: https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies

jdupak commented 2 months ago

Hi Florian, sure that should be very easy and I wanted to do it for development anyway.

I will get to it on Friday or during weekend.

It's there some established option name for this?

On Tue, 9 Jul 2024, at 08:19, Florian Schmaus wrote:

Gentoo upstream here.

It would be great if there was a CMake configuration option to select Qt5 or Qt6 (probably defaulting to autoselect). This makes it easier to reliable package qtrvsim [1]. Right now, qtrvsim basically establishes an automagic dependency on Qt, which is problematic [2].

1: https://bugs.gentoo.org/933594 2: https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies

— Reply to this email directly, view it on GitHub https://github.com/cvut/qtrvsim/issues/144, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFNB76ECGPQFWWLFPZQFYBLZLN6HDAVCNFSM6AAAAABKSFCKT2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4TOMRUG4ZTKNY. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Flowdalic commented 2 months ago

I see

being used in Gentoo. I would probably go with the first one, but no strong opinion. That said, options should be

with auto or 6 being the default.